Skip to content

Replace rqlite with modernc.org/sqlite #6515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2025
Merged

Replace rqlite with modernc.org/sqlite #6515

merged 3 commits into from
Nov 14, 2025
+68 −13

Conversation

@s3rj1k
Copy link
Contributor

@s3rj1k s3rj1k commented Oct 14, 2025 •
edited by twz123
Loading

Description

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@s3rj1k s3rj1k requested review from a team as code owners October 14, 2025 00:06
@s3rj1k s3rj1k force-pushed the modernc.org/sqlite branch 2 times, most recently from 735d1ff to bcb7ef7 Compare October 14, 2025 08:29
@twz123 twz123 mentioned this pull request Oct 14, 2025
Closed
@twz123 twz123 linked an issue Oct 14, 2025 that may be closed by this pull request
Check if possible to sunset cgo sqlite3 dependency #3051
Closed
twz123
twz123 reviewed Oct 14, 2025
View reviewed changes
Copy link
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Has been in the backlog since forever ^^

@s3rj1k s3rj1k force-pushed the modernc.org/sqlite branch from bcb7ef7 to 4aeb03b Compare October 14, 2025 09:48
twz123
twz123 reviewed Oct 27, 2025
View reviewed changes
@twz123
Copy link
Member

twz123 commented Nov 5, 2025

@s3rj1k #6568 has been merged. Would you be able to rebase this and address the few nits?

@s3rj1k s3rj1k force-pushed the modernc.org/sqlite branch from 4aeb03b to 606034b Compare November 5, 2025 09:02
@s3rj1k
Copy link
Contributor Author

s3rj1k commented Nov 5, 2025 •
edited
Loading

@s3rj1k #6568 has been merged. Would you be able to rebase this and address the few nits?

Done, except that VACUUM change, lets test that a bit later

@s3rj1k s3rj1k force-pushed the modernc.org/sqlite branch from a0008cd to 69840d3 Compare November 7, 2025 10:21
s3rj1k and others added 2 commits November 14, 2025 11:03
@s3rj1k
Replace rqlite with modernc.org/sqlite
66f7f9b 
Signed-off-by: s3rj1k <[email protected]>
@s3rj1k @twz123
Use URL Schema
86f374c 
Co-authored-by: Tom Wieczorek <[email protected]>
Signed-off-by: Serhii Ivanov <[email protected]>
@s3rj1k s3rj1k force-pushed the modernc.org/sqlite branch from babddd3 to 86f374c Compare November 14, 2025 10:04
@s3rj1k @twz123
Avoid using fmt in db.Exec
aeb587c 
Co-authored-by: Tom Wieczorek <[email protected]>
Signed-off-by: Serhii Ivanov <[email protected]>
@twz123 twz123 merged commit 2df25c4 into k0sproject:main Nov 14, 2025
200 of 201 checks passed
@s3rj1k s3rj1k deleted the modernc.org/sqlite branch November 14, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twz123 twz123 twz123 approved these changes

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas juanluisvaladas is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check if possible to sunset cgo sqlite3 dependency

2 participants

@s3rj1k @twz123